From c785d6af6679554028264c3767015ba2a7ecbe67 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Wed, 8 May 2013 16:00:15 -0700 Subject: [PATCH] [release-branch.go1.1] cmd/cgo: pass -Wsystem-headers when looking for errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit ««« CL 9120045 / e4f62df3e6c9 cmd/cgo: pass -Wsystem-headers when looking for errors This works around a bug in GCC 4.8.0. Fixes #5118. R=golang-dev, r, minux.ma CC=golang-dev https://golang.org/cl/9120045 »»» R=golang-dev, r CC=golang-dev https://golang.org/cl/9259047 --- src/cmd/cgo/gcc.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/cmd/cgo/gcc.go b/src/cmd/cgo/gcc.go index 8288a490ac..bc7a6472f3 100644 --- a/src/cmd/cgo/gcc.go +++ b/src/cmd/cgo/gcc.go @@ -809,6 +809,15 @@ func (p *Package) gccDefines(stdin []byte) string { func (p *Package) gccErrors(stdin []byte) string { // TODO(rsc): require failure args := p.gccCmd() + + // GCC 4.8.0 has a bug: it sometimes does not apply + // -Wunused-value to values that are macros defined in system + // headers. See issue 5118. Adding -Wsystem-headers avoids + // that problem. This will produce additional errors, but it + // doesn't matter because we will ignore all errors that are + // not marked for the cgo-test file. + args = append(args, "-Wsystem-headers") + if *debugGcc { fmt.Fprintf(os.Stderr, "$ %s <