From cb30430af84a220f67d4cedc47c273c31051d291 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Tue, 10 Sep 2019 14:42:50 -0400 Subject: [PATCH] go/internal/gccgoimporter: remove guard on some assertions Remove unnecessary conditional guard for a couple of assertions in the type parser's update() method (inspired by comment from Robert). No change in functionality. Change-Id: I706a54569e75c6960768247889b7dec3f267dde9 Reviewed-on: https://go-review.googlesource.com/c/go/+/194565 Run-TryBot: Than McIntosh TryBot-Result: Gobot Gobot Reviewed-by: Robert Griesemer --- src/go/internal/gccgoimporter/parser.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/go/internal/gccgoimporter/parser.go b/src/go/internal/gccgoimporter/parser.go index c089b5e054..9204b004f9 100644 --- a/src/go/internal/gccgoimporter/parser.go +++ b/src/go/internal/gccgoimporter/parser.go @@ -475,13 +475,11 @@ func (p *parser) reserve(n int) { // used to resolve pointers to named types in case they are referenced // by embedded fields. func (p *parser) update(t types.Type, nlist []interface{}) { - if len(nlist) != 0 { - if t == reserved { - p.errorf("internal error: update(%v) invoked on reserved", nlist) - } - if t == nil { - p.errorf("internal error: update(%v) invoked on nil", nlist) - } + if t == reserved { + p.errorf("internal error: update(%v) invoked on reserved", nlist) + } + if t == nil { + p.errorf("internal error: update(%v) invoked on nil", nlist) } for _, n := range nlist { switch n := n.(type) { -- 2.50.0