From ccaa4913864d49137012d04a0cd3ddf2d8ffc015 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 11 Apr 2019 16:35:56 -0400 Subject: [PATCH] cmd/go: log failures to remove workdir Failures here don't otherwise affect the build, but they do cause a slow file leak in the user's temp directory. The user deserves at least a cursory warning that something may be amiss. Updates #30789 Change-Id: Id0e72b1967e7f7c88cdc94d532554496653f264b Reviewed-on: https://go-review.googlesource.com/c/go/+/171764 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Jay Conrod --- src/cmd/go/internal/work/action.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go index 415df94f4a..052811d34a 100644 --- a/src/cmd/go/internal/work/action.go +++ b/src/cmd/go/internal/work/action.go @@ -242,7 +242,11 @@ func (b *Builder) Init() { } if !cfg.BuildWork { workdir := b.WorkDir - base.AtExit(func() { os.RemoveAll(workdir) }) + base.AtExit(func() { + if err := os.RemoveAll(workdir); err != nil { + fmt.Fprintf(os.Stderr, "go: failed to remove work dir: %s\n", err) + } + }) } } -- 2.50.0