From cd03fd05b55b3b22d31a56a9df388c72a96e62c2 Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Thu, 29 Aug 2019 15:11:55 -0400 Subject: [PATCH] runtime: remove unnecessary variable decls in asm.s runtime/asm.s contains two variable declarations that don't seem needed. The variables are defined in Go and not referenced in assembly. They were added in 2014 during the C to Go transition. Maybe they were useful at that time, but not now. Remove them. Change-Id: Id00d724813d18db47126c2f2b8cacfc9d77ffd4b Reviewed-on: https://go-review.googlesource.com/c/go/+/192378 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements --- src/runtime/asm.s | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/runtime/asm.s b/src/runtime/asm.s index 6b209b2d1f..c886d4e722 100644 --- a/src/runtime/asm.s +++ b/src/runtime/asm.s @@ -12,9 +12,6 @@ DATA runtime·no_pointers_stackmap+0x00(SB)/4, $2 DATA runtime·no_pointers_stackmap+0x04(SB)/4, $0 GLOBL runtime·no_pointers_stackmap(SB),RODATA, $8 -GLOBL runtime·mheap_(SB), NOPTR, $0 -GLOBL runtime·memstats(SB), NOPTR, $0 - // NaCl requires that these skips be verifiable machine code. #ifdef GOARCH_amd64 #define SKIP4 BYTE $0x90; BYTE $0x90; BYTE $0x90; BYTE $0x90 -- 2.50.0