From ce3a5c0d1036bea6d0abb9ff638f3a5382e428ee Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 29 Sep 2022 09:33:07 -0400 Subject: [PATCH] os/exec: avoid leaking a process in TestDoubleStartLeavesPipesOpen Updates #52580. For #50436. Change-Id: I0929055ffca1ca429f6ebec7d877f4268bd1fda2 Reviewed-on: https://go-review.googlesource.com/c/go/+/436656 TryBot-Result: Gopher Robot Run-TryBot: Bryan Mills Auto-Submit: Bryan Mills Reviewed-by: Benny Siegert --- src/os/exec/exec_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/os/exec/exec_test.go b/src/os/exec/exec_test.go index 07ac0cf3d4..822f606d66 100644 --- a/src/os/exec/exec_test.go +++ b/src/os/exec/exec_test.go @@ -1108,9 +1108,16 @@ func TestDoubleStartLeavesPipesOpen(t *testing.T) { if err != nil { t.Fatal(err) } + if err := cmd.Start(); err != nil { t.Fatal(err) } + t.Cleanup(func() { + if err := cmd.Wait(); err != nil { + t.Error(err) + } + }) + if err := cmd.Start(); err == nil || !strings.HasSuffix(err.Error(), "already started") { t.Fatalf("second call to Start returned a nil; want an 'already started' error") } -- 2.48.1