From ce77a4640561567ab59c481dd917b4f98b723b97 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Wed, 31 Aug 2022 09:37:22 +0700 Subject: [PATCH] cmd/dist: disable cgo when testing internal linking of PIE Since when internal linking cgo on some platforms, like android, is not fully supported. Updates #46731 Change-Id: I344a763f8dfb0cce04371d9305eee634bfd9ee77 Reviewed-on: https://go-review.googlesource.com/c/go/+/426199 Auto-Submit: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Russ Cox Reviewed-by: Bryan Mills --- src/cmd/dist/test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 6372054929..37fc5eaae0 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -718,7 +718,8 @@ func (t *tester) registerTests() { name: "pie_internal", heading: "internal linking of -buildmode=pie", fn: func(dt *distTest) error { - t.addCmd(dt, "src", t.goTest(), "reflect", "-buildmode=pie", "-ldflags=-linkmode=internal", t.timeout(60)) + cmd := t.addCmd(dt, "src", t.goTest(), "reflect", "-buildmode=pie", "-ldflags=-linkmode=internal", t.timeout(60)) + setEnv(cmd, "CGO_ENABLED", "0") return nil }, }) -- 2.50.0