From cf2c2ea89d09d486bb018b1817c5874388038c3a Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Sun, 3 Jun 2018 07:26:16 -0700 Subject: [PATCH] text/tabwriter: fix BenchmarkPyramid and BenchmarkRagged again These were added in CL 106979. I got them wrong. They were fixed in CL 111643. They were still wrong. Hopefully this change will be the last fix. With this fix, CL 106979 is allocation-neutral for BenchmarkRagged. The performance results for BenchmarkPyramid reported in CL 111643 stand. Change-Id: Id6a522e6602e5df31f504adf5a3bec9969c18649 Reviewed-on: https://go-review.googlesource.com/116015 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Robert Griesemer --- src/text/tabwriter/tabwriter_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/text/tabwriter/tabwriter_test.go b/src/text/tabwriter/tabwriter_test.go index 2dddd5233c..07bae0ca0b 100644 --- a/src/text/tabwriter/tabwriter_test.go +++ b/src/text/tabwriter/tabwriter_test.go @@ -693,7 +693,6 @@ func BenchmarkPyramid(b *testing.B) { for _, x := range [...]int{10, 100, 1000} { // Build a line with x cells. line := bytes.Repeat([]byte("a\t"), x) - line = append(line, '\n') b.Run(fmt.Sprintf("%d", x), func(b *testing.B) { b.ReportAllocs() for i := 0; i < b.N; i++ { @@ -712,9 +711,8 @@ func BenchmarkPyramid(b *testing.B) { func BenchmarkRagged(b *testing.B) { var lines [8][]byte for i, w := range [8]int{6, 2, 9, 5, 5, 7, 3, 8} { - // Build a line with x cells. + // Build a line with w cells. lines[i] = bytes.Repeat([]byte("a\t"), w) - lines[i] = append(lines[i], '\n') } for _, h := range [...]int{10, 100, 1000} { b.Run(fmt.Sprintf("%d", h), func(b *testing.B) { -- 2.50.0