From cf3134a0178c1c5a2c1b523dbdfa953dbf60481b Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Wed, 9 Sep 2015 11:01:01 -0700 Subject: [PATCH] cmd/doc: the builtin package should always show unexported symbols Trivial fix: set unexported=true for builtin. Godoc itself has a similar hack. Fixes #12541 Change-Id: Ib701f867d117931eb6ec6de223941b52eb6cd4a7 Reviewed-on: https://go-review.googlesource.com/14441 Reviewed-by: Brad Fitzpatrick --- src/cmd/doc/main.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/cmd/doc/main.go b/src/cmd/doc/main.go index 0985d95b60..1f503e92fa 100644 --- a/src/cmd/doc/main.go +++ b/src/cmd/doc/main.go @@ -87,6 +87,7 @@ func do(writer io.Writer, flagSet *flag.FlagSet, args []string) (err error) { buildPackage, userPath, symbol := parseArgs(flagSet.Args()) symbol, method := parseSymbol(symbol) pkg := parsePackage(writer, buildPackage, userPath) + defer func() { pkg.flush() e := recover() @@ -100,6 +101,13 @@ func do(writer io.Writer, flagSet *flag.FlagSet, args []string) (err error) { } panic(e) }() + + // The builtin package needs special treatment: its symbols are lower + // case but we want to see them, always. + if pkg.build.ImportPath == "builtin" { + unexported = true + } + switch { case symbol == "": pkg.packageDoc() -- 2.48.1