From cfae61b65a66d958367270d4d58ce7996a4987b7 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Sat, 13 May 2017 08:29:47 -0700 Subject: [PATCH] cmd/compile: tweak ssa.html colors Make yellow the last highlight color rather than the first. Yellow is also the color that Chrome uses to highlight search results, which can be confusing. Also, when Night Shift is on on macOS, yellow highlighting is completely invisible. I suppose should be sleeping instead. Also, remove a completed TODO. Change-Id: I0eb4439272fad9ccb5fe8e2cf409fdd5dc15b26e Reviewed-on: https://go-review.googlesource.com/43463 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/ssa/html.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cmd/compile/internal/ssa/html.go b/src/cmd/compile/internal/ssa/html.go index e98c5dc460..d554907beb 100644 --- a/src/cmd/compile/internal/ssa/html.go +++ b/src/cmd/compile/internal/ssa/html.go @@ -142,13 +142,13 @@ dd.ssa-prog { `) - // TODO: Add javascript click handlers for blocks - // to outline that block across all phases w.WriteString("") w.WriteString("

") w.WriteString(html.EscapeString(name)) -- 2.50.0