From d0459766c8d6b503fda7a8d9983b4aaf92a63e01 Mon Sep 17 00:00:00 2001 From: Michael Pratt Date: Thu, 1 Jun 2023 12:34:20 -0400 Subject: [PATCH] runtime: update skips for TestGdbBacktrace One issue simply has a reworded message, probably from a new version of GDB. Another is a new issue. Fixes #60553. Fixes #58698. Updates #39204. Change-Id: I8389aa981fab5421f57ee761bfb5e1dd237709ed Reviewed-on: https://go-review.googlesource.com/c/go/+/499975 Reviewed-by: Bryan Mills Run-TryBot: Michael Pratt Auto-Submit: Michael Pratt TryBot-Result: Gopher Robot Reviewed-by: Austin Clements --- src/runtime/runtime-gdb_test.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 1577d0995d..19069f4462 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -470,15 +470,17 @@ func TestGdbBacktrace(t *testing.T) { got, err := cmd.CombinedOutput() t.Logf("gdb output:\n%s", got) if err != nil { - if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) { + switch { + case bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")): // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28551 testenv.SkipFlaky(t, 43068) - } - if bytes.Contains(got, []byte("Couldn't get registers: No such process.")) { + case bytes.Contains(got, []byte("Couldn't get registers: No such process.")), bytes.Contains(got, []byte("Unable to fetch general registers.: No such process.")): // GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086 testenv.SkipFlaky(t, 50838) - } - if bytes.Contains(got, []byte(" exited normally]\n")) { + case bytes.Contains(got, []byte("waiting for new child: No child processes.")): + // GDB bug: Sometimes it fails to wait for a clone child. + testenv.SkipFlaky(t, 60553) + case bytes.Contains(got, []byte(" exited normally]\n")): // GDB bug: Sometimes the inferior exits fine, // but then GDB hangs. testenv.SkipFlaky(t, 37405) -- 2.50.0