From d086c5c81f6e19e1dce0a17d901fec071b9394ff Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 31 Oct 2018 09:32:51 -0700 Subject: [PATCH] cmd/go: don't pass empty string to ar when using -compiler=gccgo Correct error introduced in CL 145417 on non-AIX systems. Fixes #28511 Change-Id: I6624939061425af19faccedd271f465d1fe6b975 Reviewed-on: https://go-review.googlesource.com/c/146277 Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/go/internal/work/gccgo.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/work/gccgo.go b/src/cmd/go/internal/work/gccgo.go index ca3be4fd36..b89d07ead0 100644 --- a/src/cmd/go/internal/work/gccgo.go +++ b/src/cmd/go/internal/work/gccgo.go @@ -186,12 +186,12 @@ func (gccgoToolchain) pack(b *Builder, a *Action, afile string, ofiles []string) for _, f := range ofiles { absOfiles = append(absOfiles, mkAbs(objdir, f)) } - var arArgs string + var arArgs []string if cfg.Goos == "aix" && cfg.Goarch == "ppc64" { // AIX puts both 32-bit and 64-bit objects in the same archive. // Tell the AIX "ar" command to only care about 64-bit objects. // AIX "ar" command does not know D option. - arArgs = "-X64" + arArgs = []string{"-X64"} } return b.run(a, p.Dir, p.ImportPath, nil, "ar", arArgs, "rc", mkAbs(objdir, afile), absOfiles) -- 2.48.1