From d189bdd6846f1b7569d71cdcd5eeb77931f5c570 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 11 Oct 2019 08:58:52 -0400 Subject: [PATCH] internal/reflectlite: skip TestMirrorWithReflect reflect package source is unavailable Fixes #34847 Change-Id: Ibb58c8820cdab8b9f3755fcfba754ad0c9ca982f Reviewed-on: https://go-review.googlesource.com/c/go/+/200657 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Elias Naur --- src/internal/reflectlite/reflect_mirror_test.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/internal/reflectlite/reflect_mirror_test.go b/src/internal/reflectlite/reflect_mirror_test.go index 59d3ec407e..fbb6fb397e 100644 --- a/src/internal/reflectlite/reflect_mirror_test.go +++ b/src/internal/reflectlite/reflect_mirror_test.go @@ -87,6 +87,13 @@ func loadTypes(path, pkgName string, v visitor) { } func TestMirrorWithReflect(t *testing.T) { + reflectDir := filepath.Join(runtime.GOROOT(), "src", "reflect") + if _, err := os.Stat(reflectDir); os.IsNotExist(err) { + // On some mobile builders, the test binary executes on a machine without a + // complete GOROOT source tree. + t.Skipf("GOROOT source not present") + } + var wg sync.WaitGroup rl, r := newVisitor(), newVisitor() @@ -95,7 +102,7 @@ func TestMirrorWithReflect(t *testing.T) { v visitor }{ {".", "reflectlite", rl}, - {filepath.Join(runtime.GOROOT(), "src", "reflect"), "reflect", r}, + {reflectDir, "reflect", r}, } { tc := tc wg.Add(1) -- 2.50.0