From d21cef1f8f7b09bac11642a705078675e8e59164 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 17 Mar 2015 15:28:57 -0400 Subject: [PATCH] runtime: remove pointless harvestwbufs Currently we harvestwbufs the moment we enter the mark phase, even before starting the world again. Since cached wbufs are only filled when we're in mark or mark termination, they should all be empty at this point, making the harvest pointless. Remove the harvest. We should, but do not currently harvest at the end of the mark phase when we're running out of work to do. Change-Id: I5f4ba874f14dd915b8dfbc4ee5bb526eecc2c0b4 Reviewed-on: https://go-review.googlesource.com/7669 Reviewed-by: Rick Hudson --- src/runtime/mgc.go | 1 - 1 file changed, 1 deletion(-) diff --git a/src/runtime/mgc.go b/src/runtime/mgc.go index 541dbc615d..0b15a8500d 100644 --- a/src/runtime/mgc.go +++ b/src/runtime/mgc.go @@ -336,7 +336,6 @@ func gc(mode int) { // Sync. stoptheworld() gcphase = _GCmark - harvestwbufs() // Concurrent mark. starttheworld() -- 2.48.1