From d307bd4ede254d73412fede200f2ab1d188c3f54 Mon Sep 17 00:00:00 2001 From: Leon Klingele Date: Sat, 2 Mar 2019 19:58:13 +0000 Subject: [PATCH] encoding/gob: properly ignore errors Change-Id: I8827cef0f57459384329c50c51795350da0ede4b GitHub-Last-Rev: c9ad9e12b5a0fff47c21a8c299b762b64b8c9c7c GitHub-Pull-Request: golang/go#30010 Reviewed-on: https://go-review.googlesource.com/c/go/+/160434 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Bryan C. Mills --- src/encoding/gob/decgen.go | 4 +++- src/encoding/gob/encgen.go | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/encoding/gob/decgen.go b/src/encoding/gob/decgen.go index bad4fe5d92..1c31e66625 100644 --- a/src/encoding/gob/decgen.go +++ b/src/encoding/gob/decgen.go @@ -185,10 +185,12 @@ func main() { log.Fatal("source format error:", err) } fd, err := os.Create(*output) - _, err = fd.Write(source) if err != nil { log.Fatal(err) } + if _, err := fd.Write(source); err != nil { + log.Fatal(err) + } } func printMaps(b *bytes.Buffer, upperClass string) { diff --git a/src/encoding/gob/encgen.go b/src/encoding/gob/encgen.go index 0c051d2e84..409b8c9d95 100644 --- a/src/encoding/gob/encgen.go +++ b/src/encoding/gob/encgen.go @@ -164,10 +164,12 @@ func main() { log.Fatal("source format error:", err) } fd, err := os.Create(*output) - _, err = fd.Write(source) if err != nil { log.Fatal(err) } + if _, err := fd.Write(source); err != nil { + log.Fatal(err) + } } func printMaps(b *bytes.Buffer, upperClass string) { -- 2.50.0