From d547ae2a8e2879aa330b9236e28873ddd714c1f8 Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Thu, 29 Sep 2022 20:49:07 +0800 Subject: [PATCH] cmd/internal/cov: use io.SeekStart, io.SeekCurrent, and io.SeekEnd Change-Id: Ibf7e33e42c649783eaa0e638babff22d96ab51c8 Reviewed-on: https://go-review.googlesource.com/c/go/+/436701 TryBot-Result: Gopher Robot Auto-Submit: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Dmitri Shuralyov Reviewed-by: Ian Lance Taylor --- src/cmd/internal/cov/mreader.go | 6 +++--- src/cmd/internal/cov/readcovdata.go | 3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/cmd/internal/cov/mreader.go b/src/cmd/internal/cov/mreader.go index c20bccd3b2..17dcfff05b 100644 --- a/src/cmd/internal/cov/mreader.go +++ b/src/cmd/internal/cov/mreader.go @@ -72,12 +72,12 @@ func (r *MReader) Seek(offset int64, whence int) (int64, error) { return r.rdr.MustSeek(offset, whence), nil } switch whence { - case os.SEEK_SET: + case io.SeekStart: r.off = offset return offset, nil - case os.SEEK_CUR: + case io.SeekCurrent: return r.off, nil - case os.SEEK_END: + case io.SeekEnd: r.off = int64(len(r.fileView)) + offset return r.off, nil } diff --git a/src/cmd/internal/cov/readcovdata.go b/src/cmd/internal/cov/readcovdata.go index 9e660649eb..263148b993 100644 --- a/src/cmd/internal/cov/readcovdata.go +++ b/src/cmd/internal/cov/readcovdata.go @@ -11,6 +11,7 @@ import ( "internal/coverage/decodecounter" "internal/coverage/decodemeta" "internal/coverage/pods" + "io" "os" ) @@ -191,7 +192,7 @@ func (r *CovDataReader) visitPod(p pods.Pod) error { return r.fatal("unable to stat metafile %s: %v", p.MetaFile, err) } fileView := br.SliceRO(uint64(fi.Size())) - br.MustSeek(0, os.SEEK_SET) + br.MustSeek(0, io.SeekStart) r.verb(1, "fileView for pod is length %d", len(fileView)) -- 2.50.0