From d7553d9af916682e9f68d1a1aa585a12293ed1f8 Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Tue, 30 Jun 2020 18:41:24 -0400 Subject: [PATCH] cmd/link: mark special symbols reachable The special symbols are linker-created symbols for special purposes, therefore reachable (otherwise the linker won't create them). Mark them so, so they get converted to sym.Symbols when we convert to old symbol representation. In particular, the failure for building shared library on PPC64 is due to .TOC. symbol not being converted to sym.Symbol, but referenced in addmoduledata. Change-Id: Iaf5d145ffa5d15122e86a6e6983514e56dd5d456 Reviewed-on: https://go-review.googlesource.com/c/go/+/240620 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: Than McIntosh --- src/cmd/link/internal/ld/lib.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 61ccc28a1d..7b6fd9594d 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -157,6 +157,7 @@ const AfterLoadlibFull = 2 func (ctxt *Link) mkArchSym(which int, name string, ver int, ls *loader.Sym, ss **sym.Symbol) { if which == BeforeLoadlibFull { *ls = ctxt.loader.LookupOrCreateSym(name, ver) + ctxt.loader.SetAttrReachable(*ls, true) } else { *ss = ctxt.loader.Syms[*ls] } @@ -167,6 +168,7 @@ func (ctxt *Link) mkArchSym(which int, name string, ver int, ls *loader.Sym, ss func (ctxt *Link) mkArchSymVec(which int, name string, ver int, ls []loader.Sym, ss []*sym.Symbol) { if which == BeforeLoadlibFull { ls[ver] = ctxt.loader.LookupOrCreateSym(name, ver) + ctxt.loader.SetAttrReachable(ls[ver], true) } else if ls[ver] != 0 { ss[ver] = ctxt.loader.Syms[ls[ver]] } -- 2.50.0