From d82c9a167d9e3a09eb27a00b6125e1a3fea6dc3d Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Tue, 15 Jan 2019 19:37:17 +1100 Subject: [PATCH] path/filepath: skip part of TestNTNamespaceSymlink Recent CL 156398 extended TestNTNamespaceSymlink. But new code fails, if user running the test does not have sufficient privilege to create file symlink. Skip part of TestNTNamespaceSymlink, if user cannot create symlink. Fixes #29745 Change-Id: Ie4176429ba9dd98553ce9e91fd19851cc7353f42 Reviewed-on: https://go-review.googlesource.com/c/157917 Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot Reviewed-by: Tobias Klauser --- src/path/filepath/path_windows_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/path/filepath/path_windows_test.go b/src/path/filepath/path_windows_test.go index 3fcccfab78..d1735d39bd 100644 --- a/src/path/filepath/path_windows_test.go +++ b/src/path/filepath/path_windows_test.go @@ -550,6 +550,9 @@ func TestNTNamespaceSymlink(t *testing.T) { t.Errorf(`EvalSymlinks(%q): got %q, want %q`, dirlink, got, want) } + // Make sure we have sufficient privilege to run mklink command. + testenv.MustHaveSymlink(t) + file := filepath.Join(tmpdir, "file") err = ioutil.WriteFile(file, []byte(""), 0666) if err != nil { -- 2.50.0