From d9d87edc56e72808b004a80e8c6846bde690d6c1 Mon Sep 17 00:00:00 2001 From: Quim Muntal Date: Thu, 6 Feb 2025 13:16:34 -0800 Subject: [PATCH] Revert "cmd/go: report gcc ld error message when linking fails" This reverts CL 646315. Reason for revert: broke cgo_undef test Change-Id: Ic992a1666a446736c605a8caefa77f791dceb64c Reviewed-on: https://go-review.googlesource.com/c/go/+/647415 Reviewed-by: Cherry Mui Reviewed-by: Ian Lance Taylor LUCI-TryBot-Result: Go LUCI --- src/cmd/go/internal/work/exec.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go index 8e5d481033..c79d6f73ef 100644 --- a/src/cmd/go/internal/work/exec.go +++ b/src/cmd/go/internal/work/exec.go @@ -2208,7 +2208,7 @@ func (b *Builder) gccld(a *Action, objdir, outfile string, flags []string, objs } cmdargs := []any{cmd, "-o", outfile, objs, flags} - out, err := sh.runOut(base.Cwd(), b.cCompilerEnv(), cmdargs...) + _, err := sh.runOut(base.Cwd(), b.cCompilerEnv(), cmdargs...) // Note that failure is an expected outcome here, so we report output only // in debug mode and don't report the error. @@ -2217,7 +2217,7 @@ func (b *Builder) gccld(a *Action, objdir, outfile string, flags []string, objs if err != nil { saw = "failed" } - sh.ShowCmd("", "%s # test for internal linking errors (%s)\n%s", joinUnambiguously(str.StringList(cmdargs...)), saw, out) + sh.ShowCmd("", "%s # test for internal linking errors (%s)", joinUnambiguously(str.StringList(cmdargs...)), saw) } return err -- 2.51.0