From dc0455225acdc98685064964defc6df7cd3d4c40 Mon Sep 17 00:00:00 2001 From: Leon Klingele Date: Fri, 22 Feb 2019 15:51:40 +0000 Subject: [PATCH] net: explain why we ignore the first line of Plan 9 interface-status files Change-Id: Ia0847790a597c35ebb572db6fc1b7534ecf8f006 GitHub-Last-Rev: 03f039d0abbce0e2a2bf15201948e46354950a22 GitHub-Pull-Request: golang/go#30022 Reviewed-on: https://go-review.googlesource.com/c/160446 Reviewed-by: Brad Fitzpatrick --- src/net/interface_plan9.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/net/interface_plan9.go b/src/net/interface_plan9.go index e5d77390f8..8fe9138406 100644 --- a/src/net/interface_plan9.go +++ b/src/net/interface_plan9.go @@ -152,10 +152,14 @@ func interfaceAddrTable(ifi *Interface) ([]Addr, error) { } defer statusf.close() + // Read but ignore first line as it only contains the table header. + // See https://9p.io/magic/man2html/3/ip + if _, ok := statusf.readLine(); !ok { + return nil, errors.New("cannot read header line for interface: " + status) + } line, ok := statusf.readLine() - line, ok = statusf.readLine() if !ok { - return nil, errors.New("cannot parse IP address for interface: " + status) + return nil, errors.New("cannot read IP address for interface: " + status) } // This assumes only a single address for the interface. -- 2.50.0