From dc243f257bc5b9aff59782abae35a2868d593947 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Fri, 7 Apr 2017 10:53:40 -0700 Subject: [PATCH] cmd/compile/internal/types: don't return *Sym from Pushdcl (it's never used) Change-Id: Ib55f7ea3f7dcd9d02f6027121663870a65cb886c Reviewed-on: https://go-review.googlesource.com/39924 Reviewed-by: Matthew Dempsky --- src/cmd/compile/internal/gc/noder.go | 2 +- src/cmd/compile/internal/types/scope.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/cmd/compile/internal/gc/noder.go b/src/cmd/compile/internal/gc/noder.go index 1ad19df7df..3d6eaf6e81 100644 --- a/src/cmd/compile/internal/gc/noder.go +++ b/src/cmd/compile/internal/gc/noder.go @@ -909,7 +909,7 @@ func (p *noder) commClauses(clauses []*syntax.CommClause) []*Node { func (p *noder) labeledStmt(label *syntax.LabeledStmt) *Node { lhs := p.nod(label, OLABEL, p.newname(label.Label), nil) - lhs.Sym = types.Dclstack + lhs.Sym = types.Dclstack // context, for goto restriction var ls *Node if label.Stmt != nil { // TODO(mdempsky): Should always be present. diff --git a/src/cmd/compile/internal/types/scope.go b/src/cmd/compile/internal/types/scope.go index dfb63e9352..9ee3f796f7 100644 --- a/src/cmd/compile/internal/types/scope.go +++ b/src/cmd/compile/internal/types/scope.go @@ -46,10 +46,9 @@ func push(pos src.XPos) *Sym { // Pushdcl pushes the current declaration for symbol s (if any) so that // it can be shadowed by a new declaration within a nested block scope. -func Pushdcl(s *Sym, pos src.XPos) *Sym { +func Pushdcl(s *Sym, pos src.XPos) { d := push(pos) dcopy(d, s) - return d } // Popdcl pops the innermost block scope and restores all symbol declarations -- 2.48.1