From dcd1c3103295c9f3251ac1eb45e1c585127476fd Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 3 May 2023 11:22:53 -0400 Subject: [PATCH] runtime: skip TestSegv/SegvInCgo earlier on ios It appears to sometimes hang instead of crashing, which can cause subsequent tests to time out. For #59947. Change-Id: Id4ac3c0cd5f7f345334d3e0ed3f48e40b9ff191c Reviewed-on: https://go-review.googlesource.com/c/go/+/492075 TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Reviewed-by: Cherry Mui Run-TryBot: Bryan Mills --- src/runtime/crash_cgo_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index f771493b1a..9efe202085 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -643,6 +643,10 @@ func TestSegv(t *testing.T) { } t.Run(test, func(t *testing.T) { + if test == "SegvInCgo" && runtime.GOOS == "ios" { + testenv.SkipFlaky(t, 59947) // Don't even try, in case it times out. + } + t.Parallel() got := runTestProg(t, "testprogcgo", test) t.Log(got) -- 2.50.0