From de72c43f78cf31e672cfc93474c9bbb8a1eec925 Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Sun, 30 Sep 2018 16:07:27 +1000 Subject: [PATCH] net: skip TestUnixConnLocalWindows on windows/386 Recent CL 125456 implemented Unix Socket functionality on windows. But that functionality does not appear to be working when 32-bit code is used. So disable TestUnixConnLocalWindows. windows/386 builder does not appear to be complaining about TestUnixConnLocalWindows, because new functionality requires Windows 10 Build 17063. windows/386 builder uses Windows 2008. Fixes #27943 Change-Id: Iea91b86aaa124352d198ca0cd03fff1e7542f949 Reviewed-on: https://go-review.googlesource.com/138676 Run-TryBot: Alex Brainman TryBot-Result: Gobot Gobot Reviewed-by: Yasuhiro MATSUMOTO Reviewed-by: Ian Lance Taylor --- src/net/unixsock_windows_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/net/unixsock_windows_test.go b/src/net/unixsock_windows_test.go index a1da5d4062..d856e3fd81 100644 --- a/src/net/unixsock_windows_test.go +++ b/src/net/unixsock_windows_test.go @@ -10,6 +10,7 @@ import ( "internal/syscall/windows/registry" "os" "reflect" + "runtime" "strconv" "testing" ) @@ -33,6 +34,9 @@ func isBuild17063() bool { } func TestUnixConnLocalWindows(t *testing.T) { + if runtime.GOARCH == "386" { + t.Skip("not supported on windows/386, see golang.org/issue/27943") + } if !isBuild17063() { t.Skip("unix test") } -- 2.50.0