From e084d844208621d0d9c060f8322d242adb26e845 Mon Sep 17 00:00:00 2001 From: Joel Sing Date: Tue, 13 Sep 2022 19:32:34 +1000 Subject: [PATCH] cmd/internal/objabi: declare HeadType String on a non-pointer receiver objabi.HeadType is typically used as a non-pointer type, however the String function is declared on a pointer receiver. This means that in most cases its integer value is printed, rather than the value from the String function. Change-Id: I3d28d9680e88a714bc1152ed5e1df4ac43d7a33f Reviewed-on: https://go-review.googlesource.com/c/go/+/430556 Run-TryBot: Cherry Mui TryBot-Result: Gopher Robot Reviewed-by: Jenny Rakoczy Reviewed-by: Cherry Mui Auto-Submit: Jenny Rakoczy --- src/cmd/internal/objabi/head.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cmd/internal/objabi/head.go b/src/cmd/internal/objabi/head.go index 48ff292307..763910fbd6 100644 --- a/src/cmd/internal/objabi/head.go +++ b/src/cmd/internal/objabi/head.go @@ -80,8 +80,8 @@ func (h *HeadType) Set(s string) error { return nil } -func (h *HeadType) String() string { - switch *h { +func (h HeadType) String() string { + switch h { case Haix: return "aix" case Hdarwin: @@ -105,5 +105,5 @@ func (h *HeadType) String() string { case Hwindows: return "windows" } - return fmt.Sprintf("HeadType(%d)", *h) + return fmt.Sprintf("HeadType(%d)", h) } -- 2.50.0