From e1b49ad608c0b51acf75f8248e1167acbbcb5d30 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Fri, 8 Feb 2019 11:22:48 +0000 Subject: [PATCH] doc: remove last pieces of advice to set GOROOT MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit install.html still insisted that GOROOT must be set if a binary install of Go is set up in a custom directory. However, since 1.10, this has been unnecessary as the GOROOT will be found based on the location of the 'go' binary being run. Likewise, install-source.html includes an 'export GOROOT' line in a section that only talks about explicitly setting GOARCH and GOOS, which is optional. We don't want to have users think it is recommended to set GOROOT here either, so remove the unnecessary line. Change-Id: I7dfef09f9a1d003e0253b793d63ea40d5cf1837f Reviewed-on: https://go-review.googlesource.com/c/161758 Reviewed-by: Andrew Bonventre Reviewed-by: Ian Lance Taylor Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot --- doc/install-source.html | 1 - doc/install.html | 5 ----- 2 files changed, 6 deletions(-) diff --git a/doc/install-source.html b/doc/install-source.html index 2d12a28869..6d416d33f1 100644 --- a/doc/install-source.html +++ b/doc/install-source.html @@ -666,7 +666,6 @@ something like this: 

-export GOROOT=$HOME/go1.X
 export GOARCH=amd64
 export GOOS=linux
diff --git a/doc/install.html b/doc/install.html index ab192031c4..a41c60ba6c 100644 --- a/doc/install.html +++ b/doc/install.html @@ -171,11 +171,6 @@ command prompts for the change to take effect. Download the zip file and extract it into the directory of your choice (we suggest c:\Go).

-

-If you chose a directory other than c:\Go, -you must set the GOROOT environment variable to your chosen path. -

-

Add the bin subdirectory of your Go root (for example, c:\Go\bin) to your PATH environment variable.

-- 2.50.0