From e1df20edbb27c6fb273f530f1b4c6911c3b2e919 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 5 Nov 2019 11:01:10 -0500 Subject: [PATCH] [release-branch.go1.13] cmd/go/internal/modfetch: remove non-hermetic test The test for gopkg.in/yaml.v2@v2 assumes that there are no future upstream releases. That assumption empirically does not hold. Backporting fixes to this test is annoying, and other gopkg.in cases are already reasonably covered, so remove the problematic test. Updates #28856 Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17 Reviewed-on: https://go-review.googlesource.com/c/go/+/205437 Run-TryBot: Bryan C. Mills Reviewed-by: Brad Fitzpatrick (cherry picked from commit f0390ffc9d461cb84207b5a94c4b645c87673406) Reviewed-on: https://go-review.googlesource.com/c/go/+/205438 Reviewed-by: Alexander Rakoczy TryBot-Result: Gobot Gobot --- src/cmd/go/internal/modfetch/coderepo_test.go | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/cmd/go/internal/modfetch/coderepo_test.go b/src/cmd/go/internal/modfetch/coderepo_test.go index 663324b3dd..4b84191b3e 100644 --- a/src/cmd/go/internal/modfetch/coderepo_test.go +++ b/src/cmd/go/internal/modfetch/coderepo_test.go @@ -334,16 +334,6 @@ var codeRepoTests = []codeRepoTest{ time: time.Date(2016, 12, 8, 18, 13, 25, 0, time.UTC), gomod: "module gopkg.in/check.v1\n", }, - { - vcs: "git", - path: "gopkg.in/yaml.v2", - rev: "v2", - version: "v2.2.5-0.20191002202810-970885f01c8b", - name: "970885f01c8bc1fecb7ab1c8ce8e7609bda45530", - short: "970885f01c8b", - time: time.Date(2019, 10, 2, 20, 28, 10, 0, time.UTC), - gomod: "module \"gopkg.in/yaml.v2\"\n\nrequire (\n\t\"gopkg.in/check.v1\" v0.0.0-20161208181325-20d25e280405\n)\n", - }, { vcs: "git", path: "vcs-test.golang.org/go/mod/gitrepo1", -- 2.48.1