From e2a30b8ffba065ea45bb1e18d1bb584898e3bf11 Mon Sep 17 00:00:00 2001 From: Kenny Grant Date: Sat, 21 May 2016 17:19:22 +0100 Subject: [PATCH] time: genzabbrs.go skips Feb when checking months getAbbrs looks like it is checking each month looking for a change in the time zone abbreviation, but starts in Dec of the previous year and skips the month of February because of the overflow rules for AddDate. Changing the day to 1 starts at Jan 1 and tries all months in the current year. This isn't very important or likely to change output as zones usually span several months. Discovered when looking into time.AddDate behavior when adding months. Change-Id: I685254c8d21c402ba82cc4176e9a86b64ce8f7f7 Reviewed-on: https://go-review.googlesource.com/23322 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/time/genzabbrs.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/time/genzabbrs.go b/src/time/genzabbrs.go index 9eb0728a42..6281f73ce4 100644 --- a/src/time/genzabbrs.go +++ b/src/time/genzabbrs.go @@ -30,7 +30,7 @@ var filename = flag.String("output", "zoneinfo_abbrs_windows.go", "output file n // getAbbrs finds timezone abbreviations (standard and daylight saving time) // for location l. func getAbbrs(l *time.Location) (st, dt string) { - t := time.Date(time.Now().Year(), 0, 0, 0, 0, 0, 0, l) + t := time.Date(time.Now().Year(), 0, 1, 0, 0, 0, 0, l) abbr1, off1 := t.Zone() for i := 0; i < 12; i++ { t = t.AddDate(0, 1, 0) -- 2.50.0