From e2d278bfeb2f0f117efc50b3f0f9dcb086a45ed2 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 7 Dec 2020 15:26:24 -0500 Subject: [PATCH] [dev.regabi] cmd/compile: two small fixes Addressing comments from CL 275434 and CL 275444. I forgot to run "git rw" to rebase the fixup CLs down before running "git submit". Change-Id: Ideaa2340a81511491c096555c6834cd9bdb267d8 Reviewed-on: https://go-review.googlesource.com/c/go/+/275881 Trust: Russ Cox Run-TryBot: Russ Cox TryBot-Result: Go Bot Reviewed-by: Matthew Dempsky --- src/cmd/compile/internal/ir/mknode.go | 2 +- src/cmd/compile/internal/ir/stmt.go | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/ir/mknode.go b/src/cmd/compile/internal/ir/mknode.go index 978b2de5a5..72034022cb 100644 --- a/src/cmd/compile/internal/ir/mknode.go +++ b/src/cmd/compile/internal/ir/mknode.go @@ -144,7 +144,7 @@ func forNodeFields(typName string, typ *types.Struct, f func(name string, is fun if strings.ToLower(strings.TrimSuffix(v.Name(), "_")) != "body" { continue } - case "Name", "Pack": + case "Name": continue } switch v.Name() { diff --git a/src/cmd/compile/internal/ir/stmt.go b/src/cmd/compile/internal/ir/stmt.go index ccf46dfa73..68f9b0bd7c 100644 --- a/src/cmd/compile/internal/ir/stmt.go +++ b/src/cmd/compile/internal/ir/stmt.go @@ -33,7 +33,12 @@ func (n *Decl) Left() Node { return n.X } func (n *Decl) SetLeft(x Node) { n.X = x } // A Stmt is a Node that can appear as a statement. -// This includes statement-like expressions such as <-c and f(). +// This includes statement-like expressions such as f(). +// +// (It's possible it should include <-c, but that would require +// splitting ORECV out of UnaryExpr, which hasn't yet been +// necessary. Maybe instead we will introduce ExprStmt at +// some point.) type Stmt interface { Node isStmt() -- 2.48.1