From e45c262fe55ada091a4ae53bf140ff22d9f74b35 Mon Sep 17 00:00:00 2001 From: Michael Pratt Date: Mon, 12 Feb 2024 14:32:22 -0500 Subject: [PATCH] runtime/cgo: add note about default stack bounds The default case in x_cgo_getstackbound does not actually get the stack bound of the current thread, but estimates the bound based on the default stack size. Add a comment noting this. Change-Id: I7d886461f0bbc795834bed37b554417cf3837a2d Reviewed-on: https://go-review.googlesource.com/c/go/+/563376 Auto-Submit: Michael Pratt Reviewed-by: Cherry Mui LUCI-TryBot-Result: Go LUCI --- src/runtime/cgo/gcc_stack_unix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/runtime/cgo/gcc_stack_unix.c b/src/runtime/cgo/gcc_stack_unix.c index f3fead9c9e..67efd9bc63 100644 --- a/src/runtime/cgo/gcc_stack_unix.c +++ b/src/runtime/cgo/gcc_stack_unix.c @@ -29,6 +29,8 @@ x_cgo_getstackbound(uintptr bounds[2]) pthread_attr_get_np(pthread_self(), &attr); pthread_attr_getstack(&attr, &addr, &size); // low address #else + // We don't know how to get the current stacks, so assume they are the + // same as the default stack bounds. pthread_attr_init(&attr); pthread_attr_getstacksize(&attr, &size); addr = __builtin_frame_address(0) + 4096 - size; -- 2.48.1