From e50fee06ab1404eb4e5bf7d336abca6d69ccc4b3 Mon Sep 17 00:00:00 2001 From: Sergey Matveev Date: Fri, 27 Mar 2015 19:15:23 +0300 Subject: [PATCH] Simplify external command call Signed-off-by: Sergey Matveev --- common.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/common.go b/common.go index 545274f..4d8442e 100644 --- a/common.go +++ b/common.go @@ -19,7 +19,6 @@ along with this program. If not, see . package govpn import ( - "bytes" "encoding/hex" "io/ioutil" "log" @@ -45,15 +44,11 @@ func ScriptCall(path, ifaceName string) ([]byte, error) { if _, err := os.Stat(path); err != nil && os.IsNotExist(err) { return nil, err } - cmd := exec.Command(path, ifaceName) - var out bytes.Buffer - cmd.Stdout = &out - err := cmd.Run() - result := out.Bytes() + out, err := exec.Command(path, ifaceName).CombinedOutput() if err != nil { - log.Println("Script error", path, err, string(result)) + log.Println("Script error", path, err, string(out)) } - return result, err + return out, err } // Read authentication key from the file. -- 2.48.1