From e577a55b78bb2d36841504c00ff1d984c167308e Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Mon, 6 Mar 2017 23:49:49 -0800 Subject: [PATCH] cmd/compile: change signatlist to []*Type No need to keep as Nodes when they're all Types anyway. Change-Id: I8157914ba5b09cadf2263247844680a60233a0f2 Reviewed-on: https://go-review.googlesource.com/37886 Run-TryBot: Matthew Dempsky TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/gc/reflect.go | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/cmd/compile/internal/gc/reflect.go b/src/cmd/compile/internal/gc/reflect.go index 5d5187b7e6..d2c5aafd8b 100644 --- a/src/cmd/compile/internal/gc/reflect.go +++ b/src/cmd/compile/internal/gc/reflect.go @@ -24,7 +24,7 @@ type ptabEntry struct { } // runtime interface and reflection data structures -var signatlist []*Node +var signatlist []*Type var itabs []itabEntry var ptabs []ptabEntry @@ -977,7 +977,7 @@ func typenamesym(t *Type) *Sym { n.Typecheck = 1 s.Def = n - signatlist = append(signatlist, typenod(t)) + signatlist = append(signatlist, t) } return s.Def.Sym @@ -1382,20 +1382,15 @@ ok: func dumptypestructs() { // copy types from externdcl list to signatlist for _, n := range externdcl { - if n.Op != OTYPE { - continue + if n.Op == OTYPE { + signatlist = append(signatlist, n.Type) } - signatlist = append(signatlist, n) } // Process signatlist. This can't use range, as entries are // added to the list while it is being processed. for i := 0; i < len(signatlist); i++ { - n := signatlist[i] - if n.Op != OTYPE { - continue - } - t := n.Type + t := signatlist[i] dtypesym(t) if t.Sym != nil { dtypesym(ptrto(t)) -- 2.48.1