From e87af8c43d5801c20e698aeb8c96577c4e881755 Mon Sep 17 00:00:00 2001 From: David Symonds Date: Mon, 29 Jul 2013 12:08:19 +1000 Subject: [PATCH] misc/dashboard: don't update tip tag for release branch commits. This will mean that sub-repositories won't get built against the release branch. They are often not compatible because the subrepos often run ahead of the current release (e.g. go.tools is using new additions to go/ast, and go.net is using new things in syscall) so there's little point in checking them against cherrypick commits when they'll be tested against those commits on tip anyway. R=golang-dev, adg CC=golang-dev https://golang.org/cl/12001043 --- misc/dashboard/app/build/handler.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/dashboard/app/build/handler.go b/misc/dashboard/app/build/handler.go index 1a1118641a..4ba05e3a6f 100644 --- a/misc/dashboard/app/build/handler.go +++ b/misc/dashboard/app/build/handler.go @@ -11,6 +11,7 @@ import ( "errors" "fmt" "net/http" + "strings" "appengine" "appengine/datastore" @@ -98,8 +99,8 @@ func addCommit(c appengine.Context, com *Commit) error { return errors.New("parent commit not found") } } - // update the tip Tag if this is the Go repo - if p.Path == "" { + // update the tip Tag if this is the Go repo and this isn't on a release branch + if p.Path == "" && !strings.HasPrefix(com.Desc, "[release-branch") { t := &Tag{Kind: "tip", Hash: com.Hash} if _, err = datastore.Put(c, t.Key(c), t); err != nil { return fmt.Errorf("putting Tag: %v", err) -- 2.48.1