From eb2fabf2fa4e1cb0386ae52e041c3d6b0ced3d29 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Tue, 16 Apr 2019 22:13:47 +0900 Subject: [PATCH] text/template: clarify the safety of Template.New MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In particular, the returned template isn't independent from the parent. For example, it can't be parsed concurrently with other children templates. Only methods which are explicitly safe for concurrent use, like Execute, may be used concurrently. Fixes #30281. Change-Id: Idc84bf4199c035316cdb83b950fd4a8f2a71cd0c Reviewed-on: https://go-review.googlesource.com/c/go/+/172297 Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot Reviewed-by: Andrew Gerrand --- src/text/template/template.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/text/template/template.go b/src/text/template/template.go index 41cdd5682c..1135d819b9 100644 --- a/src/text/template/template.go +++ b/src/text/template/template.go @@ -50,6 +50,10 @@ func (t *Template) Name() string { // New allocates a new, undefined template associated with the given one and with the same // delimiters. The association, which is transitive, allows one template to // invoke another with a {{template}} action. +// +// Because associated templates share underlying data, template construction +// cannot be done safely in parallel. Once the templates are constructed, they +// can be executed in parallel. func (t *Template) New(name string) *Template { t.init() nt := &Template{ -- 2.48.1