From ed99fcf1cf0347c86618bff3b46502602fd6b3c0 Mon Sep 17 00:00:00 2001 From: "Fangming.Fang" Date: Thu, 24 May 2018 08:36:00 +0000 Subject: [PATCH] cmd/dist: run msan test only in testsanitizer on arm64 With latest gcc (7.3.0), misc/cgo/testsanitizer test will fail with reporting sigmentation fault when running tsan test. On arm64, tsan is not supported currently and only msan test can be run. So skip tsan test on arm64. What needs to be pointed out is that msan test can be really run when setting clang as c/c++ complier. Fixes #25601 Change-Id: I6ab1a8d9edd243e2ee00ee40bc0abd6a0e6a125c Reviewed-on: https://go-review.googlesource.com/114857 Reviewed-by: Bryan C. Mills Reviewed-by: Ian Lance Taylor Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot --- misc/cgo/testsanitizers/tsan_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/misc/cgo/testsanitizers/tsan_test.go b/misc/cgo/testsanitizers/tsan_test.go index ec4e0033fb..314b5072f3 100644 --- a/misc/cgo/testsanitizers/tsan_test.go +++ b/misc/cgo/testsanitizers/tsan_test.go @@ -7,9 +7,13 @@ package sanitizers_test import ( "strings" "testing" + "runtime" ) func TestTSAN(t *testing.T) { + if runtime.GOARCH == "arm64" { + t.Skip("skipping test; see https://golang.org/issue/25682") + } t.Parallel() requireOvercommit(t) config := configure("thread") -- 2.50.0