From edbef1a848c744536384c3fd41e264026ad73edb Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Thu, 18 May 2023 11:40:19 -0700 Subject: [PATCH] go/types, types2: remove unnecessary assignment (minor cleanup) Change-Id: I77e5056a159b6041ca49480a3c493a515d4b3a2f Reviewed-on: https://go-review.googlesource.com/c/go/+/496255 Reviewed-by: Robert Findley Reviewed-by: Robert Griesemer Run-TryBot: Robert Griesemer Auto-Submit: Robert Griesemer TryBot-Result: Gopher Robot --- src/cmd/compile/internal/types2/builtins.go | 7 +++---- src/go/types/builtins.go | 7 +++---- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/cmd/compile/internal/types2/builtins.go b/src/cmd/compile/internal/types2/builtins.go index 1a79fc8ebd..e8c0859fa0 100644 --- a/src/cmd/compile/internal/types2/builtins.go +++ b/src/cmd/compile/internal/types2/builtins.go @@ -636,12 +636,11 @@ func (check *Checker) builtin(x *operand, call *syntax.CallExpr, id builtinId) ( if nargs > 0 { params = make([]Type, nargs) for i, a := range args { - *x = *a - check.assignment(x, nil, "argument to "+predeclaredFuncs[id].name) - if x.mode == invalid { + check.assignment(a, nil, "argument to "+predeclaredFuncs[id].name) + if a.mode == invalid { return } - params[i] = x.typ + params[i] = a.typ } } diff --git a/src/go/types/builtins.go b/src/go/types/builtins.go index 80cfeb3880..d40d8d77cc 100644 --- a/src/go/types/builtins.go +++ b/src/go/types/builtins.go @@ -635,12 +635,11 @@ func (check *Checker) builtin(x *operand, call *ast.CallExpr, id builtinId) (_ b if nargs > 0 { params = make([]Type, nargs) for i, a := range args { - *x = *a - check.assignment(x, nil, "argument to "+predeclaredFuncs[id].name) - if x.mode == invalid { + check.assignment(a, nil, "argument to "+predeclaredFuncs[id].name) + if a.mode == invalid { return } - params[i] = x.typ + params[i] = a.typ } } -- 2.48.1