From ee706cfe83ec1bbb95e7ebe29c640544510c732b Mon Sep 17 00:00:00 2001 From: Leon Klingele Date: Tue, 5 Nov 2019 16:19:42 +0000 Subject: [PATCH] net/smtp: add missing error check in test Change-Id: Ifcbd9d2961073a18a250f052180248d9bf223e97 GitHub-Last-Rev: 67f97d1ca07665979504264986e25522ed6799f8 GitHub-Pull-Request: golang/go#30018 Reviewed-on: https://go-review.googlesource.com/c/go/+/160442 Reviewed-by: Brad Fitzpatrick --- src/net/smtp/smtp_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/net/smtp/smtp_test.go b/src/net/smtp/smtp_test.go index 2ad7dd0978..cfda0790e9 100644 --- a/src/net/smtp/smtp_test.go +++ b/src/net/smtp/smtp_test.go @@ -656,9 +656,16 @@ func TestSendMailWithAuth(t *testing.T) { tc := textproto.NewConn(conn) tc.PrintfLine("220 hello world") msg, err := tc.ReadLine() - if msg == "EHLO localhost" { - tc.PrintfLine("250 mx.google.com at your service") + if err != nil { + errCh <- fmt.Errorf("ReadLine error: %v", err) + return + } + const wantMsg = "EHLO localhost" + if msg != wantMsg { + errCh <- fmt.Errorf("unexpected response %q; want %q", msg, wantMsg) + return } + err = tc.PrintfLine("250 mx.google.com at your service") if err != nil { errCh <- fmt.Errorf("PrintfLine: %v", err) return -- 2.50.0