From eedd97d5fd9d7b773dc7b1b8d7e00e137da091bb Mon Sep 17 00:00:00 2001 From: Jonathan Amsterdam Date: Tue, 21 Mar 2023 08:57:43 -0400 Subject: [PATCH] log/slog: clarify Logger.WithGroup doc Make it clear that "qualified by the given name" doesn't imply any particular implementation, but depends on how the Handler treats groups. Updates golang/go#56345. Change-Id: Idf52553108bc1a7d2091a06cc4fc4cc0fc52cc14 Reviewed-on: https://go-review.googlesource.com/c/go/+/478056 Reviewed-by: Alan Donovan TryBot-Result: Gopher Robot Run-TryBot: Jonathan Amsterdam --- src/log/slog/logger.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/log/slog/logger.go b/src/log/slog/logger.go index fc734b2ba6..f58add9af9 100644 --- a/src/log/slog/logger.go +++ b/src/log/slog/logger.go @@ -109,6 +109,8 @@ func (l *Logger) With(args ...any) *Logger { // WithGroup returns a new Logger that starts a group. The keys of all // attributes added to the Logger will be qualified by the given name. +// (How that qualification happens depends on the [Handler.WithGroup] +// method of the Logger's Handler.) // The new Logger shares the old Logger's context. // // The new Logger's handler is the result of calling WithGroup on the receiver's -- 2.48.1