From f12683a83114b9240bea9715fba563647deed72d Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Wed, 8 Apr 2020 11:54:11 -0400 Subject: [PATCH] [dev.link] cmd/link: ignore undefined symbols in trampoline generation Don't emit an error for undefined symbol in trampoline generation pass, which will be duplicate as we'll emit a better one later. Fix TestUndefinedRelocErrors on PPC64. Change-Id: I964d4bd63ec4b4c6eb5d98caf68db93ce6488bf5 Reviewed-on: https://go-review.googlesource.com/c/go/+/227617 Run-TryBot: Cherry Zhang Reviewed-by: Than McIntosh TryBot-Result: Gobot Gobot --- src/cmd/link/internal/ld/data.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/data.go b/src/cmd/link/internal/ld/data.go index 3a1f355056..f72262cf4d 100644 --- a/src/cmd/link/internal/ld/data.go +++ b/src/cmd/link/internal/ld/data.go @@ -101,7 +101,7 @@ func trampoline(ctxt *Link, s loader.Sym) { continue } rs := r.Sym() - if !ldr.AttrReachable(rs) { + if !ldr.AttrReachable(rs) || ldr.SymType(rs) == sym.Sxxx { continue // something is wrong. skip it here and we'll emit a better error later } rs = ldr.ResolveABIAlias(rs) -- 2.50.0