From f298b90bc56540e4313b7b7d3ecf08b1390b644f Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 27 Jan 2023 15:33:48 -0500 Subject: [PATCH] cmd/dist: set GOFLAGS=-trimpath when building cmd for releases MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Also set it on the Go builders, so that the builders more closely match releases. It looks like this change was intended to be included in CL 454836, but was commented out at some point — perhaps during debugging? — before that change was merged. For #24904. Change-Id: Ib501274520c5de366d4e9d87a1bd3c6ba2d2413f Reviewed-on: https://go-review.googlesource.com/c/go/+/463740 Run-TryBot: Bryan Mills TryBot-Result: Gopher Robot Reviewed-by: Russ Cox Auto-Submit: Bryan Mills --- src/cmd/dist/build.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/cmd/dist/build.go b/src/cmd/dist/build.go index 1b6a2ceae0..d388058d9e 100644 --- a/src/cmd/dist/build.go +++ b/src/cmd/dist/build.go @@ -1296,10 +1296,7 @@ func toolenv() []string { // Do not include local development, so that people working in the // main branch for day-to-day work on the Go toolchain itself can // still have full paths for stack traces for compiler crashes and the like. - // - // TODO(bcmills): This was added but commented out in CL 454836. - // Uncomment or delete it. - // env = append(env, "GOFLAGS=-trimpath") + env = append(env, "GOFLAGS=-trimpath") } return env } -- 2.50.0