From f35868a49a6b337806faf49824c6dba1870c2649 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Sun, 19 Jul 2015 18:20:06 -0700 Subject: [PATCH] cmd/go: don't run TestInstalls in short mode It changes GOROOT, so we shouldn't run it in short mode. Also, it's fairly slow. Update #11779. Change-Id: I3d3344954cf9b2ac70070c878a67cb65ac8fd85c Reviewed-on: https://go-review.googlesource.com/12364 Run-TryBot: Ian Lance Taylor Reviewed-by: Andrew Gerrand --- src/cmd/go/go_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 804901cb5a..93f6cadf66 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -1207,6 +1207,10 @@ func TestGoGetNonPkg(t *testing.T) { } func TestInstalls(t *testing.T) { + if testing.Short() { + t.Skip("don't install into GOROOT in short mode") + } + tg := testgo(t) defer tg.cleanup() tg.parallel() -- 2.50.0