From f4e4ec2cd09c2f9d821f3cb6f47edd7c41a90b25 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 21 Aug 2018 14:27:07 +0200 Subject: [PATCH] cmd/cover: fix off-by-one error in TestCoverHTML Avoid index out of range if len(goldenLines) == len(outLines) + 1 Change-Id: Ic23a85d2b8dd06a615e35a58331e78abe4ad6703 Reviewed-on: https://go-review.googlesource.com/130396 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/cover/cover_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/cover/cover_test.go b/src/cmd/cover/cover_test.go index c818819c39..8eb7124aad 100644 --- a/src/cmd/cover/cover_test.go +++ b/src/cmd/cover/cover_test.go @@ -314,7 +314,7 @@ func TestCoverHTML(t *testing.T) { // Compare at the line level, stopping at first different line so // we don't generate tons of output if there's an inserted or deleted line. for i, goldenLine := range goldenLines { - if i > len(outLines) { + if i >= len(outLines) { t.Fatalf("output shorter than golden; stops before line %d: %s\n", i+1, goldenLine) } // Convert all white space to simple spaces, for easy comparison. -- 2.50.0