From f52ce42274573d39386f3bacc77ab2ef969d5a0d Mon Sep 17 00:00:00 2001 From: Hiroshi Ioka Date: Thu, 17 Aug 2017 09:16:32 +0900 Subject: [PATCH] debug/macho: add comments for ambiguious LoadCommand While LoadCmdDylib represents LC_LOAD_DYLIB, LoadCmdDylinker represents LC_ID_DYLINKER. This is confusing because there is another command called LC_LOAD_DYLINKER. LC_ID_DYLINKER is not included in normal binary, it is only used for /usr/lib/dyld as far as I know. So, perhaps this is a mistake. Change-Id: I6ea61664a26998962742914af5688e094a233541 Reviewed-on: https://go-review.googlesource.com/56330 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/debug/macho/macho.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/debug/macho/macho.go b/src/debug/macho/macho.go index 0010775f45..045adb090a 100644 --- a/src/debug/macho/macho.go +++ b/src/debug/macho/macho.go @@ -84,8 +84,8 @@ const ( LoadCmdThread LoadCmd = 0x4 LoadCmdUnixThread LoadCmd = 0x5 // thread+stack LoadCmdDysymtab LoadCmd = 0xb - LoadCmdDylib LoadCmd = 0xc - LoadCmdDylinker LoadCmd = 0xf + LoadCmdDylib LoadCmd = 0xc // load dylib command + LoadCmdDylinker LoadCmd = 0xf // id dylinker command (not load dylinker command) LoadCmdSegment64 LoadCmd = 0x19 ) -- 2.50.0