From f5526b56dbf45ce1f2e856f4aa78674dd0b5afe3 Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Tue, 29 Oct 2024 14:57:06 +0000 Subject: [PATCH] runtime: skip TestNewOSProc0 with asan and msan These fail for the same reason as for the race detector, and is the most frequently failing test in both. For #70054. For #64257. For #64256. Change-Id: I3649e58069190b4450f9d4deae6eb8eca5f827a3 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-asan-clang15,gotip-linux-amd64-msan-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/623176 TryBot-Bypass: Michael Knyszek Reviewed-by: Cherry Mui --- src/runtime/{norace_linux_test.go => nosan_linux_test.go} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename src/runtime/{norace_linux_test.go => nosan_linux_test.go} (76%) diff --git a/src/runtime/norace_linux_test.go b/src/runtime/nosan_linux_test.go similarity index 76% rename from src/runtime/norace_linux_test.go rename to src/runtime/nosan_linux_test.go index 3521b24655..5c99591a07 100644 --- a/src/runtime/norace_linux_test.go +++ b/src/runtime/nosan_linux_test.go @@ -2,9 +2,9 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// The file contains tests that cannot run under race detector for some reason. +// The file contains tests that cannot run under race detector (or asan or msan) for some reason. // -//go:build !race +//go:build !race && !asan && !msan package runtime_test @@ -23,7 +23,7 @@ func newOSProcCreated() { newOSProcDone = true } -// Can't be run with -race because it inserts calls into newOSProcCreated() +// Can't be run with -race, -asan, or -msan because it inserts calls into newOSProcCreated() // that require a valid G/M. func TestNewOSProc0(t *testing.T) { runtime.NewOSProc0(0x800000, unsafe.Pointer(abi.FuncPCABIInternal(newOSProcCreated))) -- 2.48.1