From f91ab6c0256877841944c57a12bd779edb2a0f66 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Sun, 19 Nov 2017 13:40:05 +0000 Subject: [PATCH] bytes: don't use an iota for the readOp constants MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit As per the comments in golang.org/cl/78617. Also leaving a comment here, to make sure noone else thinks to re-introduce the iota like I did. Change-Id: I2a2275998b81896eaa0e9d5ee0197661ebe84acf Reviewed-on: https://go-review.googlesource.com/78676 Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/bytes/buffer.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/bytes/buffer.go b/src/bytes/buffer.go index 83bb1c7eb5..67771846fc 100644 --- a/src/bytes/buffer.go +++ b/src/bytes/buffer.go @@ -30,13 +30,15 @@ type Buffer struct { // converted to int they correspond to the rune size that was read. type readOp int8 +// Don't use iota for these, as the values need to correspond with the +// names and comments, which is easier to see when being explicit. const ( - opRead readOp = iota - 1 // Any other read operation. - opInvalid // Non-read operation. - opReadRune1 // Read rune of size 1. - opReadRune2 // Read rune of size 2. - opReadRune3 // Read rune of size 3. - opReadRune4 // Read rune of size 4. + opRead readOp = -1 // Any other read operation. + opInvalid readOp = 0 // Non-read operation. + opReadRune1 readOp = 1 // Read rune of size 1. + opReadRune2 readOp = 2 // Read rune of size 2. + opReadRune3 readOp = 3 // Read rune of size 3. + opReadRune4 readOp = 4 // Read rune of size 4. ) // ErrTooLarge is passed to panic if memory cannot be allocated to store data in a buffer. -- 2.48.1