From f96fa06d14dfb41d987ae5372084e593ac535b13 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 3 Jul 2015 12:32:40 -0700 Subject: [PATCH] net/http/fcgi: fix race between serveRequest and cleanUp Fixes #11552 Change-Id: I87904e9e3fb4bd1fb4c7075a4e2d0151e5bd37df Reviewed-on: https://go-review.googlesource.com/11890 Run-TryBot: Brad Fitzpatrick Reviewed-by: Mikio Hara Reviewed-by: David Crawshaw --- src/net/http/fcgi/child.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/net/http/fcgi/child.go b/src/net/http/fcgi/child.go index aba71cd5c1..da824ed717 100644 --- a/src/net/http/fcgi/child.go +++ b/src/net/http/fcgi/child.go @@ -289,6 +289,8 @@ func (c *child) serveRequest(req *request, body io.ReadCloser) { } func (c *child) cleanUp() { + c.mu.Lock() + defer c.mu.Unlock() for _, req := range c.requests { if req.pw != nil { // race with call to Close in c.serveRequest doesn't matter because -- 2.50.0