From fa62ea6927d81202342289b2b15398886ea4f3bb Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Sun, 5 Nov 2017 19:36:35 -0500 Subject: [PATCH] cmd/dist: do not reinstall runtime/cgo with -tags lldb on ios builders The cache will take care of keeping go test -tags lldb fast. Installing runtime/cgo this way just makes all the checkNotStale tests think runtime/cgo is out of date. Should fix ios builders. Fixes #22509. Change-Id: If092cc4feb189eb848b6a22f6d22b89b70df219c Reviewed-on: https://go-review.googlesource.com/76020 Run-TryBot: Russ Cox Reviewed-by: David Crawshaw --- src/cmd/dist/test.go | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 7c0d53efb9..9f185af55e 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -139,29 +139,6 @@ func (t *tester) run() { checkNotStale("go", "std", "cmd") } - if t.iOS() { - // Install the Mach exception handler used to intercept - // EXC_BAD_ACCESS and convert it into a Go panic. This is - // necessary for a Go program running under lldb (the way - // we run tests). It is disabled by default because iOS - // apps are not allowed to access the exc_server symbol. - cmd := exec.Command("go", "install", "-a", "-tags", "lldb", "runtime/cgo") - cmd.Stdout = os.Stdout - cmd.Stderr = os.Stderr - if err := cmd.Run(); err != nil { - log.Fatalf("building mach exception handler: %v", err) - } - - defer func() { - cmd := exec.Command("go", "install", "-a", "runtime/cgo") - cmd.Stdout = os.Stdout - cmd.Stderr = os.Stderr - if err := cmd.Run(); err != nil { - log.Fatalf("reverting mach exception handler: %v", err) - } - }() - } - t.timeoutScale = 1 switch goarch { case "arm": -- 2.48.1