From fab47f7b3a9d8ad91b96bf80f0b9dff2feda31d2 Mon Sep 17 00:00:00 2001 From: Vladimir Stefanovic Date: Tue, 6 Jun 2017 16:13:39 +0200 Subject: [PATCH] net/http: enable TestLinuxSendfile on mips64 The test is passing on a 64bit RFS. Fixes #18008 Change-Id: Ia4c4f4dde0392c7f6bbe5dbffc97cf848ec5a107 Reviewed-on: https://go-review.googlesource.com/44953 Reviewed-by: Brad Fitzpatrick --- src/net/http/fs_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/net/http/fs_test.go b/src/net/http/fs_test.go index 1bb24d3060..f1037c4b5c 100644 --- a/src/net/http/fs_test.go +++ b/src/net/http/fs_test.go @@ -1091,12 +1091,10 @@ func TestLinuxSendfile(t *testing.T) { syscalls := "sendfile,sendfile64" switch runtime.GOARCH { - case "mips64le", "s390x": + case "mips64", "mips64le", "s390x": // strace on the above platforms doesn't support sendfile64 // and will error out if we specify that with `-e trace='. syscalls = "sendfile" - case "mips64": - t.Skip("TODO: update this test to be robust against various versions of strace on mips64. See golang.org/issue/18008") } // Attempt to run strace, and skip on failure - this test requires SYS_PTRACE. -- 2.50.0