From fafd792de30f46cbd822fd6bb041c60c7b5fbe6d Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Wed, 6 Jan 2016 14:37:45 -0500 Subject: [PATCH] net: fix hostLookupOrder("") Fixes #13623. Change-Id: I1bd96aa7b6b715e4dbdcf0c37c2d29228df6565c Reviewed-on: https://go-review.googlesource.com/18329 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/net/conf.go | 2 +- src/net/conf_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/net/conf.go b/src/net/conf.go index 48372e5197..eb729167f5 100644 --- a/src/net/conf.go +++ b/src/net/conf.go @@ -220,7 +220,7 @@ func (c *conf) hostLookupOrder(hostname string) (ret hostLookupOrder) { var first string for _, src := range srcs { if src.source == "myhostname" { - if hasDot { + if hostname == "" || hasDot { continue } return fallbackOrder diff --git a/src/net/conf_test.go b/src/net/conf_test.go index 8f39847804..ec8814b845 100644 --- a/src/net/conf_test.go +++ b/src/net/conf_test.go @@ -257,6 +257,7 @@ func TestConfHostLookupOrder(t *testing.T) { hostTests: []nssHostTest{ {"x.com", hostLookupFilesDNS}, {"somehostname", hostLookupCgo}, + {"", hostLookupFilesDNS}, // Issue 13623 }, }, { -- 2.50.0