From fb75c2da91b9cccf05ec6baad2636325c5d96751 Mon Sep 17 00:00:00 2001 From: Cherry Mui Date: Thu, 9 Jun 2022 17:30:05 -0400 Subject: [PATCH] cmd/dist, cmd/internal/metadata: don't install metadata binary It is only needed by cmd/dist, no need to build and install the binary. Change-Id: I6aba6b81496406077a0efba255c35020cff9d351 Reviewed-on: https://go-review.googlesource.com/c/go/+/411534 TryBot-Result: Gopher Robot Reviewed-by: Michael Pratt Run-TryBot: Cherry Mui --- src/cmd/dist/test.go | 2 +- src/cmd/internal/metadata/main.go | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 677be336ac..26d7fe0f73 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -290,7 +290,7 @@ func (t *tester) maybeLogMetadata() error { // // TODO(prattmic): If we split dist bootstrap and dist test then this // could be simplified to directly use internal/sysinfo here. - return t.dirCmd(filepath.Join(goroot, "src/cmd/internal/metadata"), "go", []string{"run", "."}).Run() + return t.dirCmd(filepath.Join(goroot, "src/cmd/internal/metadata"), "go", []string{"run", "main.go"}).Run() } // short returns a -short flag value to use with 'go test' diff --git a/src/cmd/internal/metadata/main.go b/src/cmd/internal/metadata/main.go index 157226e890..7478eec1c9 100644 --- a/src/cmd/internal/metadata/main.go +++ b/src/cmd/internal/metadata/main.go @@ -5,6 +5,12 @@ // Metadata prints basic system metadata to include in test logs. This is // separate from cmd/dist so it does not need to build with the bootstrap // toolchain. + +// This program is only used by cmd/dist. Add an "ignore" build tag so it +// is not installed. cmd/dist does "go run main.go" directly. + +//go:build ignore + package main import ( -- 2.50.0