From ff6b6c61d7818e4a32402acbf65940afa372368e Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Thu, 31 Mar 2022 14:58:20 -0400 Subject: [PATCH] net: skip tests that use netsh on the windows-arm64-10 builder These tests sometimes hang on Windows 10 on ARM64, due to what appears to be a platform bug. Since we have not yet observed any such hangs on the windows-arm64-11 builder, I am leaving the tests otherwise enabled on the theory that the platform bug may have been fixed in Windows 11. Fixes #52082 (at least for now). Change-Id: I79161f485b1921f083ebcf01865d6e7b0178ef70 Reviewed-on: https://go-review.googlesource.com/c/go/+/397315 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Ian Lance Taylor TryBot-Result: Gopher Robot --- src/net/net_windows_test.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/net/net_windows_test.go b/src/net/net_windows_test.go index 2a563a078c..947dda56f2 100644 --- a/src/net/net_windows_test.go +++ b/src/net/net_windows_test.go @@ -8,6 +8,7 @@ import ( "bufio" "bytes" "fmt" + "internal/testenv" "io" "os" "os/exec" @@ -205,6 +206,13 @@ func runCmd(args ...string) ([]byte, error) { } func checkNetsh(t *testing.T) { + if testenv.Builder() == "windows-arm64-10" { + // netsh was observed to sometimes hang on this builder. + // We have not observed failures on windows-arm64-11, so for the + // moment we are leaving the test enabled elsewhere on the theory + // that it may have been a platform bug fixed in Windows 11. + testenv.SkipFlaky(t, 52082) + } out, err := runCmd("netsh", "help") if err != nil { t.Fatal(err) -- 2.50.0