From ffbd194f5cf399a98578ea950c969d07a751ecfd Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Tue, 10 Jan 2023 15:22:11 -0800 Subject: [PATCH] test: remove TODO in issue20250.go This has been investigated and explained on the issue tracker. Fixes #54402. Change-Id: I4d8b971faa810591983ad028b7db16411f3b3b4a Reviewed-on: https://go-review.googlesource.com/c/go/+/461456 Reviewed-by: Cuong Manh Le Run-TryBot: Matthew Dempsky TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui Reviewed-by: Benny Siegert --- test/fixedbugs/issue20250.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/fixedbugs/issue20250.go b/test/fixedbugs/issue20250.go index 7c6e796e8e..a6283c7595 100644 --- a/test/fixedbugs/issue20250.go +++ b/test/fixedbugs/issue20250.go @@ -14,12 +14,10 @@ type T struct { s [2]string } -func f(a T) { // ERROR "live at entry to f: a" +func f(a T) { // ERROR "live at entry to f: a$" var e interface{} // ERROR "stack object e interface \{\}$" - // TODO(go.dev/issue/54402): Investigate why "live at entry to - // f.func1" is sensitive to regabi. - func() { // ERROR "live at entry to f.func1: (a &e|&e a)" - e = a.s // ERROR "live at call to convT: &e" "stack object a T$" + func() { // ERROR "live at entry to f.func1: &e a$" + e = a.s // ERROR "live at call to convT: &e$" "stack object a T$" }() // Before the fix, both a and e were live at the previous line. _ = e -- 2.48.1